Drop gtk_widget_event from API
authorMatthias Clasen <mclasen@redhat.com>
Mon, 17 Feb 2020 12:40:31 +0000 (07:40 -0500)
committerMatthias Clasen <mclasen@redhat.com>
Fri, 21 Feb 2020 05:51:03 +0000 (00:51 -0500)
We don't want events to be injected randomly from
the outside. Plus, there's no way to create such
events from the outside now.

gtk/gtkwidget.c
gtk/gtkwidget.h
gtk/gtkwidgetprivate.h

index 3dd9b5cf6e154e4a1b3efca1621da8b7ebfd8062..cb87bd0f44c38cba03c3e3ecd724b9c641fd926a 100644 (file)
@@ -635,9 +635,6 @@ static void             gtk_widget_propagate_state              (GtkWidget
                                                                  const GtkStateData *data);
 static void             gtk_widget_update_alpha                 (GtkWidget        *widget);
 
-static gboolean         gtk_widget_event_internal               (GtkWidget        *widget,
-                                                                 GdkEvent         *event,
-                                                                 GtkWidget        *target);
 static gboolean                gtk_widget_real_mnemonic_activate       (GtkWidget        *widget,
                                                                 gboolean          group_cycling);
 static void             gtk_widget_real_measure                 (GtkWidget        *widget,
@@ -4787,32 +4784,6 @@ gtk_widget_real_mnemonic_activate (GtkWidget *widget,
 #define WIDGET_REALIZED_FOR_EVENT(widget, event) \
      (gdk_event_get_event_type (event) == GDK_FOCUS_CHANGE || _gtk_widget_get_realized (widget))
 
-/**
- * gtk_widget_event:
- * @widget: a #GtkWidget
- * @event: a #GdkEvent
- *
- * Rarely-used function. This function is used to emit
- * the event signals on a widget (those signals should never
- * be emitted without using this function to do so).
- * If you want to synthesize an event though, don’t use this function;
- * instead, use gtk_main_do_event() so the event will behave as if
- * it were in the event queue.
- *
- * Returns: return from the event signal emission (%TRUE if
- *               the event was handled)
- **/
-gboolean
-gtk_widget_event (GtkWidget *widget,
-                  GdkEvent  *event,
-                  GtkWidget *target)
-{
-  g_return_val_if_fail (GTK_IS_WIDGET (widget), TRUE);
-  g_return_val_if_fail (WIDGET_REALIZED_FOR_EVENT (widget, event), TRUE);
-
-  return gtk_widget_event_internal (widget, event, target);
-}
-
 gboolean
 gtk_widget_run_controllers (GtkWidget           *widget,
                             GdkEvent            *event,
@@ -4990,10 +4961,10 @@ translate_event_coordinates (GdkEvent  *event,
   return TRUE;
 }
 
-static gboolean
-gtk_widget_event_internal (GtkWidget *widget,
-                           GdkEvent  *event,
-                           GtkWidget *target)
+gboolean
+gtk_widget_event (GtkWidget *widget,
+                  GdkEvent  *event,
+                  GtkWidget *target)
 {
   gboolean return_val = FALSE;
   double x, y;
index 4e43fff36a8147af7cfc40f03f8c9ac52fd5df95..92272125e830257e3084c404bd232043629b5208 100644 (file)
@@ -398,10 +398,6 @@ GDK_AVAILABLE_IN_ALL
 gboolean   gtk_widget_mnemonic_activate   (GtkWidget           *widget,
                                            gboolean             group_cycling);
 GDK_AVAILABLE_IN_ALL
-gboolean   gtk_widget_event               (GtkWidget           *widget,
-                                           GdkEvent            *event,
-                                           GtkWidget           *target);
-GDK_AVAILABLE_IN_ALL
 gboolean   gtk_widget_activate               (GtkWidget        *widget);
 
 GDK_AVAILABLE_IN_ALL
index 7ba6c12bcdc7081e435faf658e779451ee90a3a5..b3519f04b8b27c8a57e3133cc907d6c8ae698cde 100644 (file)
@@ -342,7 +342,9 @@ void              gtk_widget_cancel_event_sequence         (GtkWidget
                                                             GtkGesture            *gesture,
                                                             GdkEventSequence      *sequence,
                                                             GtkEventSequenceState  state);
-
+gboolean          gtk_widget_event                         (GtkWidget           *widget,
+                                                            GdkEvent            *event,
+                                                            GtkWidget           *target);
 gboolean          gtk_widget_run_controllers               (GtkWidget           *widget,
                                                             GdkEvent            *event,
                                                             GtkWidget           *target,